Don't call save on devices, links, or LOSes unnecessarily #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillNilges
commented
Jan 30, 2025
WillNilges
force-pushed
the
wdn/dirty-bit
branch
from
cde40dd to
5530895
Compare
WillNilges
force-pushed
the
wdn/dirty-bit
branch
from
5530895 to
71c4613
Compare
|
Confirmed this test fails on main and works on my branch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
+ Coverage 94.88% 94.90% +0.01%
==========================================
Files 89 89
Lines 3816 3825 +9
==========================================
+ Hits 3621 3630 +9
Misses 195 195 ☔ View full report in Codecov by Sentry. |
Andrew-Dickinson
approved these changes
Jan 31, 2025
Andrew-Dickinson
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #790
This prevents the UISP import script from calling save on our objects unnecessarily, which should stop the history tables from ballooning like they do.
See https://django-simple-history.readthedocs.io/en/3.8.0/utils.html#clean-duplicate-history for more info