Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Noise XKpsk3 integration #4360

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

Feature Noise XKpsk3 integration #4360

wants to merge 28 commits into from
+1,875 −199

Conversation

simonwicky
Copy link
Contributor

@simonwicky simonwicky commented Jan 30, 2024 •
edited by mmsinclair
Loading

Description

This is the base of stacked PRs to integrate XKpsk3 Noise connection between nym nodes

This PR concerns self-described API and Nym-API changes.

The stack of PR is as follow :
#4360 (this one) -> #4361 -> #4373 -> #4362

Checklist:

  • added a changelog entry to CHANGELOG.md

This change is Reviewable

This was referenced Jan 30, 2024
Merged
Merged
octol
octol reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@octol octol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having NoiseInformation separate from HostInformation, I take it this is for backwards compatibility? Or perhaps another reason?

Also, the Option, it seems like it's never None?

nym-api/src/node_describe_cache/mixnode.rs Outdated Show resolved Hide resolved
nym-api/src/node_describe_cache/mod.rs Outdated Show resolved Hide resolved
nym-api/src/node_describe_cache/mod.rs Show resolved Hide resolved
@simonwicky
Copy link
Contributor Author

simonwicky commented Feb 6, 2024 •
edited
Loading

Having NoiseInformation separate from HostInformation, I take it this is for backwards compatibility? Or perhaps another reason?

Yes. Backwards compatibility and temporary information for the upgrade transition

Also, the Option, it seems like it's never None?

It's None for mix nodes, so the description can be unified with gateways

@simonwicky simonwicky mentioned this pull request Feb 7, 2024
Merged
1 task
@mmsinclair mmsinclair mentioned this pull request Feb 13, 2024
Closed
@vercel Vercel
Copy link

vercel bot commented Feb 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 2:49pm

@simonwicky simonwicky changed the title Feature Noise XKpsk3 integration API Feature Noise XKpsk3 integration Feb 14, 2024
@simonwicky
Copy link
Contributor Author

PR stack has been collapsed

@simonwicky simonwicky mentioned this pull request Mar 11, 2024
Merged
1 task
@tommyv1987 tommyv1987 added this to the DoubleDecker milestone Jun 10, 2024
@benedettadavico benedettadavico modified the milestones: DoubleDecker, Wispa Jun 25, 2024
@benedettadavico benedettadavico modified the milestones: Wispa, TopDeck Jul 10, 2024
@benedettadavico benedettadavico modified the milestones: TopDeck, Caramello Jul 23, 2024
@benedettadavico benedettadavico modified the milestones: Caramello, Wedel Aug 5, 2024
@benedettadavico benedettadavico modified the milestones: Wedel, Aero Sep 11, 2024
@benedettadavico benedettadavico modified the milestones: Aero, Temporary Home Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octol octol octol approved these changes

@jstuczyn jstuczyn Awaiting requested review from jstuczyn jstuczyn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Temporary Home
Development

Successfully merging this pull request may close these issues.
4 participants
@simonwicky @octol @benedettadavico @tommyv1987