Refactor orbit/spacecraft state generator to always use the multivariate normal #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to replace the IID generator with multivariate generator. This leads to some troubles with Keplerian dispersions because the rotation matrix is not necessarily positive. I may need to disperse the orbital state independently from the rest of the state (Cr, Cd, Mass).
…on't know what it is
|
Visit the preview URL for this PR (updated for commit ef77dcc): https://nyx-rustdoc--pr340-331-measurement-upda-xc7kd37s.web.app (expires Sat, 27 Jul 2024 03:12:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
…ced this is perfect
ChristopherRabotin
deleted the
331-measurement-update-and-residual-rejection-shall-account-for-each-participants-noise-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Until this PR, the spacecraft state generator made the completely incorrect assumption that each component of a state was iid. Obviously, this is wrong. This PR aims to fix this by removing the Generator structure and replacing it with the Multivariate Normal.
This also removes the ability to sample from anything but a normal distribution: in my experience, this is all that's ever done.
Architectural Changes
Remove
Generatorstructure.New Features
No change
Improvements
No change
Bug Fixes
No change
Testing and validation
Sampling from a full Kalman Filter estimate and from a fully defined Cartesian state space is checked to meet the 99.7% criteria with 1000 samples. There is following validation work in #339 . However the "robust" OD tests have switched to this new dispersion method very successfully.
Documentation
This PR does not primarily deal with documentation changes.