-
Notifications
You must be signed in to change notification settings - Fork 50
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
unclutter the pull request template (#732)
* unclutter the pull request template * fix heading * fix pr checklist
- Loading branch information
Showing
1 changed file
with
22 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,29 @@ | ||
| # Description | ||
| Please include a summary of why this pull request should be merged. | ||
|
|
||
| Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. | ||
|
|
||
| Use smart commits here to manipulate issues (eg. Fixes #issue) | ||
|
|
||
| ## Connected issues & other potential problems | ||
| <!-- ## Connected issues & other potential problems | ||
| If changes in PR are connected to other issues or are affecting code in other parts of framework | ||
| (e.g. in main package or any other subpackage) make sure to link issue/PR and describe said problem | ||
|
|
||
| ## Type of change | ||
|
|
||
| Please delete options that are not relevant. | ||
| (e.g. in main package or any other subpackage) make sure to link issue/PR and describe said problem. | ||
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
| Uncomment this part to add context if needed. | ||
| --> | ||
|
|
||
| # Checklist: | ||
| ## Type of change | ||
|
|
||
| - [ ] Ran `dart analyze` or `make analyze` and fixed all issues | ||
| - [ ] Ran `dart format --set-exit-if-changed -l 160 ./lib` or `make format` and fixed all issues | ||
| - [ ] I have performed a self-review of my own code | ||
| - [ ] I have commented my code, particularly in hard-to-understand areas | ||
| - [ ] I have made corresponding changes to the documentation | ||
| - [ ] I have added tests that prove my fix is effective or that my feature works | ||
| <!-- | ||
| - [x] Bug fix (non-breaking change which fixes an issue) | ||
| - [x] New feature (non-breaking change which adds functionality) | ||
| - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
| Move/Copy lines that apply out of the comment. | ||
| --> | ||
|
|
||
| ## Checklist: | ||
|
|
||
| <!-- | ||
| - [x] Ran `dart analyze` or `make analyze` and fixed all issues | ||
| - [x] Ran `dart format --set-exit-if-changed -l 160 ./lib` or `make format` and fixed all issues | ||
| - [x] I have made corresponding changes to the documentation | ||
| - [x] I have added tests that prove my fix is effective or that my feature works | ||
| Move/Copy lines that apply out of the comment. | ||
| --> |