Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[saffron] integration test #3039

Open
wants to merge 3 commits into
base: martin/saffron-read-pf
Choose a base branch
from

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Feb 14, 2025

This PR tries to document all the user flow features we have in a single test: upload/update/read-proof/storage-proof. The CLI has not kept up with these flows, but hopefully this test can serve as docs for whatever comes next.

This test is in tests/integration.rs/. All other changes are small borrow/move refactors that came up naturally while trying to write it.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.07%. Comparing base (304b505) to head (fd1dcd7).

Files with missing lines Patch % Lines
saffron/src/main.rs 0.00% 2 Missing ⚠️
saffron/src/query.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           martin/saffron-read-pf    #3039      +/-   ##
==========================================================
- Coverage                   77.07%   77.07%   -0.01%     
==========================================================
  Files                         264      264              
  Lines                       62348    62349       +1     
==========================================================
- Hits                        48056    48053       -3     
- Misses                      14292    14296       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martyall martyall marked this pull request as ready for review February 16, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant