Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT - WIP] [RHELC-1717] Refactor of InstallRhelkernel #1403

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hosekadam
Copy link
Member

NOT FINISHED YET

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@hosekadam hosekadam force-pushed the fix-older-kernel-set-as-default branch 2 times, most recently from d64ff64 to f9fa8cf Compare October 15, 2024 09:21
@hosekadam hosekadam added the tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. label Oct 15, 2024
@has-bot
Copy link
Member

has-bot commented Oct 15, 2024

/packit test --labels sanity


Comment generated by an automation.

@hosekadam
Copy link
Member Author

/packit test --labels stream

@danmyway
Copy link
Member

danmyway commented Nov 5, 2024

/packit build

@danmyway danmyway force-pushed the fix-older-kernel-set-as-default branch from f9fa8cf to c716a32 Compare November 5, 2024 12:25
@danmyway danmyway added the kind/bug-fix A bug has been fixed label Nov 5, 2024
@danmyway
Copy link
Member

/packit test --labels sanity

@danmyway danmyway force-pushed the fix-older-kernel-set-as-default branch from c716a32 to cda4c18 Compare November 21, 2024 14:21
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (363d6d3) to head (3a15552).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   96.11%   96.09%   -0.02%     
==========================================
  Files          72       72              
  Lines        5177     5152      -25     
  Branches      896      889       -7     
==========================================
- Hits         4976     4951      -25     
  Misses        119      119              
  Partials       82       82              
Flag Coverage Δ
centos-linux-7 91.59% <100.00%> (-0.05%) ⬇️
centos-linux-8 92.45% <100.00%> (-0.04%) ⬇️
centos-linux-9 92.58% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@danmyway
Copy link
Member

/packit test --labels sanity

@danmyway danmyway force-pushed the fix-older-kernel-set-as-default branch from cda4c18 to 3a15552 Compare November 22, 2024 13:56
@danmyway
Copy link
Member

/packit test --labels sanity

@bocekm
Copy link
Member

bocekm commented Nov 22, 2024

I've manually tested the current state of this PR on a conversion of CentOS Stream 9 and there's been no issues with kernel.
RHEL kernel installed:

  • kernel-5.14.0-503.14.1.el9_5.x86_64

Stream kernels removed:

  • kernel-0:5.14.0-514.el9.x86_64
  • kernel-0:5.14.0-529.el9.x86_64

The installed RHEL kernel version was at the time of the conversion the latest available one. Rebooting to the RHEL kernel went ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix A bug has been fixed tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants