Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1759] Remove zero value report messages #1436

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

bocekm
Copy link
Member

@bocekm bocekm commented Nov 22, 2024

The following post-conversion messages give near zero value to the user and we shouldn't waste the users' time as they would most likely read through all of them after the conversion:

  • Skipped locking releasever (the releasever lock is needed only when converting to RHEL EUS using RHSM)
  • The RHEL kernel has been verified to be on the system
  • Skipped host metering configuration because of various reasons such as
    • when the system is not RHEL 7 running on one of the big three hyperscalers (host metering is not applicable anywhere else)
    • the user hasn't set the option to configure host metering (which is totally fine because it's not mandatory and on majority of systems it's not applicable)

Also there's essentially dead code generating a pre-conversion analysis message talking about outdated convert2rhel on RHEL 6 systems which we do not allow converting anymore.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@bocekm bocekm requested a review from danmyway November 22, 2024 22:40
@bocekm bocekm requested a review from a team as a code owner November 22, 2024 22:40
@bocekm bocekm added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. merge-after-tests-ok kind/refactor labels Nov 22, 2024
@has-bot
Copy link
Member

has-bot commented Nov 22, 2024

/packit test --labels sanity


Comment generated by an automation.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (cce2401) to head (dff25fa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   96.12%   96.11%   -0.01%     
==========================================
  Files          72       72              
  Lines        5186     5178       -8     
  Branches      896      895       -1     
==========================================
- Hits         4985     4977       -8     
  Misses        119      119              
  Partials       82       82              
Flag Coverage Δ
centos-linux-7 91.63% <100.00%> (-0.02%) ⬇️
centos-linux-8 92.49% <100.00%> (-0.02%) ⬇️
centos-linux-9 92.61% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bocekm bocekm changed the title Remove unnecessary analysis messages [RHELC-1759] Remove zero value analysis messages Nov 25, 2024
@bocekm bocekm changed the title [RHELC-1759] Remove zero value analysis messages [RHELC-1759] Remove zero value report messages Nov 25, 2024
Copy link
Member

@hosekadam hosekadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I understand why those messages can be removed, and I agree.

@bocekm bocekm force-pushed the remove-unnecessary-analysis-messages branch 2 times, most recently from 39040b0 to 44346d1 Compare December 3, 2024 14:46
@bocekm bocekm requested a review from Venefilyn December 3, 2024 14:47
The "SKIP" post-conversion messages give zero value to the user.
The "OUTDATED_CONVERT2RHEL_VERSION" pre-conversion message was for RHEL
6 only which we do not allow converting anymore.
@bocekm bocekm force-pushed the remove-unnecessary-analysis-messages branch from 223ca69 to 7e153a4 Compare December 3, 2024 14:55
@bocekm bocekm merged commit dbcd745 into oamg:main Dec 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants