-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHELC-1759] Remove zero value report messages #1436
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
==========================================
- Coverage 96.12% 96.11% -0.01%
==========================================
Files 72 72
Lines 5186 5178 -8
Branches 896 895 -1
==========================================
- Hits 4985 4977 -8
Misses 119 119
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I understand why those messages can be removed, and I agree.
39040b0
to
44346d1
Compare
The "SKIP" post-conversion messages give zero value to the user. The "OUTDATED_CONVERT2RHEL_VERSION" pre-conversion message was for RHEL 6 only which we do not allow converting anymore.
223ca69
to
7e153a4
Compare
for more information, see https://pre-commit.ci
The following post-conversion messages give near zero value to the user and we shouldn't waste the users' time as they would most likely read through all of them after the conversion:
Also there's essentially dead code generating a pre-conversion analysis message talking about outdated convert2rhel on RHEL 6 systems which we do not allow converting anymore.
Jira Issues:
Checklist
[RHELC-]
or[HMS-]
is part of the PR titleRelease Pending
if relevant