Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support max_by and min_by aggregate function #363

Closed
wants to merge 63 commits into from

Conversation

Yohahaha
Copy link

No description provided.

zhejiangxiaomai and others added 30 commits July 3, 2023 16:23
relative pr:

add decimal column reader support facebookincubator#254
Add utility method MemoryUsageTracker::highUsage() facebookincubator#227
Support parquet read case sensitive option facebookincubator#126
Make varchar and varbinary compatible facebookincubator#115
Create folder if not exits on HDFS write facebookincubator#267
relative pr:

Add expand op in velox facebookincubator#199
Add ValueStreamNode operator facebookincubator#204
Allow decimal in casting string to int facebookincubator#215
relative pr:

add support for reading ORC facebookincubator#229
Parquet: Optimize parquet write perf facebookincubator#238
Expand timestamps in page reader facebookincubator#260
Add processedStrides and processedSplits metrics facebookincubator#264
relative pr:

Fix hashjoin runtime issue facebookincubator#106
INVALID_STATE on HashJoin when spill is turned on facebookincubator#154
SIGABRT on DecimalAvgAggregate<UnscaleLongDecimal, UnscaleShortDecimal> when spilling is engaged facebookincubator#236
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
relative pr:

Allow decimal in casting string to int facebookincubator#215
Add mapping from named_struct to row_constructor facebookincubator#214
Fix semantic issues in cast function facebookincubator#280
relative pr:

Fix replace SparkSQL function facebookincubator#277
Support kPreceeding & kFollowing for window range frame type facebookincubator#287
support timestamp hash facebookincubator#269
Spark sum can overflow facebookincubator#101
Support float & double types in pmod function facebookincubator#157
Implement datetime functions in velox/sparksql. facebookincubator#81
Fix type check in MapFunction facebookincubator#273
Let function validation fail for lookaround pattern in RE2-based implementation facebookincubator#124
Register lpad/rpad functions for Spark SQL. facebookincubator#63
Support substring_index sql function facebookincubator#189
Fix First/Last aggregate functions intermediate type and support decimal facebookincubator#245
Support date_add spark sql function facebookincubator#144
relative pr:

Serialize and deserialize RowVector facebookincubator#250
relative pr:

Check a fallback case in validation: using literal partition key in window function facebookincubator#148
Fix might_contain validate fallback and support struct literal facebookincubator#137
Implement datetime functions in velox/sparksql. facebookincubator#81
Parse options in SingularOrList correctly facebookincubator#48
Add SingularOrList support facebookincubator#45
Support if then in filter facebookincubator#74
Fix semi join output type and support existence join facebookincubator#67
Support decimal as partition column facebookincubator#167
Add the window support facebookincubator#61
Add expand operator facebookincubator#65
Support more cases of filter and its pushdown facebookincubator#14
relative pr:

Support more data types for read filter facebookincubator#139
Fix cast double to decimal facebookincubator#179
Fix casting from string to decimal facebookincubator#281
Support cast decimal to int facebookincubator#177
Fix null on overflow and multiply as spark precision and support cast varchar to decimal facebookincubator#169
Disable tokenizing the path by dot facebookincubator#109
Serialize and deserialize RowVector facebookincubator#250
Support datetime pattern in spark facebookincubator#94
In Ubuntu, thrift will be installed manually in setup scripts, but Arrow still compile thrift, then Velox use system thrift and pre-build arrow/parquet.
In Centos, Velox could not found system thrift, so it will compile Arrow and thrift twice.
Since Arrow will compile thrift in all environments, lets use these pre-build shared libs to save time and keep toolchain consistency.

Support native dependency could be overrided by env variables.
ulysses-you and others added 22 commits July 3, 2023 16:29
* fix decimal add
* remove unused code
Co-authored-by: ‘zhaozhenhui’ <‘[email protected]’>
@Yohahaha
Copy link
Author

@rui-mo
Copy link
Collaborator

rui-mo commented Jul 17, 2023

Please rebase. Aggregate functions max/min_by_merge should be used to support distinct cases, could you add corresponding test in VeloxAggregateFunctionsSuite?

@Yohahaha Yohahaha closed this Jul 18, 2023
marin-ma pushed a commit to marin-ma/velox-oap that referenced this pull request Dec 15, 2023
@Yohahaha Yohahaha deleted the max_by_oap branch April 30, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.