Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert range filter changes #423

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Revert range filter changes #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aa7b3b
Revert "Expand BigintRange constructor (oap 377)"
rui-mo Oct 24, 2023
9c2c454
Revert "Expand multi range constructor (oap 378)"
rui-mo Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions velox/type/Filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,27 +665,6 @@ class BigintRange final : public Filter {
upper16_(std::min<int64_t>(upper, std::numeric_limits<int16_t>::max())),
isSingleValue_(upper_ == lower_) {}

BigintRange(
int64_t lower,
bool lowerUnbounded,
bool lowerExclusive,
int64_t upper,
bool upperUnbounded,
bool upperExclusive,
bool nullAllowed)
: Filter(true, nullAllowed, FilterKind::kBigintRange),
lower_(lowerExclusive ? lower + 1 : lower),
upper_(upperExclusive ? upper - 1 : upper),
lower32_(
std::max<int64_t>(lower_, std::numeric_limits<int32_t>::min())),
upper32_(
std::min<int64_t>(upper_, std::numeric_limits<int32_t>::max())),
lower16_(
std::max<int64_t>(lower_, std::numeric_limits<int16_t>::min())),
upper16_(
std::min<int64_t>(upper_, std::numeric_limits<int16_t>::max())),
isSingleValue_(upper_ == lower_) {}

folly::dynamic serialize() const override;

static FilterPtr create(const folly::dynamic& obj);
Expand Down Expand Up @@ -2049,13 +2028,6 @@ class MultiRange final : public Filter {
filters_(std::move(filters)),
nanAllowed_(nanAllowed) {}

MultiRange(
std::vector<std::unique_ptr<Filter>> filters,
bool nullAllowed)
: Filter(true, nullAllowed, FilterKind::kMultiRange),
filters_(std::move(filters)),
nanAllowed_(true) {}

folly::dynamic serialize() const override;

static FilterPtr create(const folly::dynamic& obj);
Expand Down
Loading