set registerCompanion and overwrite for spark max_by/min_by agg functions #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: WindowPartition::resetPartition can be consolidated with the window constructor. We call resetPartition only once per WindowPartition now. Pull Request resolved: facebookincubator#7216 Reviewed By: xiaoxmeng, Yuhta Differential Revision: D50603402 Pulled By: mbasmanova fbshipit-source-id: c0e6c0e88b935830d1874283fbc9c6c67cbb4512
Signed-off-by: Yuan Zhou <[email protected]>
|
Oops... Seems I missed this change. Will add it to the corresponding PR. |
|
Covered by 80988e4. |
|
Hi @Yohahaha, I am closing this PR since another commit already covers it. Please re-open it if you need. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.