Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Add Windows support and mention MetaMask issue #12

Merged
merged 10 commits into from
Jun 10, 2024

Conversation

caovanthanh203
Copy link
Contributor

Add alternative command to export env variable for Windows

@caovanthanh203 caovanthanh203 marked this pull request as ready for review April 13, 2024 06:58
@caovanthanh203 caovanthanh203 changed the title From bc67da8d/demo-starter/main to oasisprotocol/demo-starter/main From bc67da8d:main to oasisprotocol:main Apr 13, 2024
@matevz
Copy link
Member

matevz commented Apr 13, 2024

Can you check, if other commands (pnpm, npx, hardhat) for deployment and setMessage work as expected?

@caovanthanh203
Copy link
Contributor Author

Can you check, if other commands (pnpm, npx, hardhat) for deployment and setMessage work as expected?

Yeah, other commands works, I am using Windows so I can confirm they are good with CMD

@caovanthanh203 caovanthanh203 changed the title From bc67da8d:main to oasisprotocol:main From caovanthanh203:main to oasisprotocol:main Apr 13, 2024
frontend/.env.development Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@matevz matevz changed the title From caovanthanh203:main to oasisprotocol:main README.md: Add Windows support and mention MetaMask issue May 13, 2024
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@matevz matevz merged commit 2f77d85 into oasisprotocol:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants