Enable pagination in Events lists #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
commented
Jul 22, 2024
| if (layer === Layer.consensus) { | ||
| throw AppErrors.UnsupportedLayer | ||
| } | ||
| const eventsQuery = useGetRuntimeEvents(network, layer, { | ||
| tx_hash: transaction.hash, | ||
| limit: 100, // We want to avoid pagination here, if possible |
There was a problem hiding this comment.
Why we want to avoid pagination and why we set 100 cap?
There was a problem hiding this comment.
🤷 I can't find an explanation. 1000 limit was allowed when #224 was made
buberdds
force-pushed
the
mz/eventsPagination
branch
from
e549858 to
0e1ebc9
Compare
lukaw3d
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requested by Tadej, but I am not sure we should do it looking at comments
random test urls
tx
https://dc9c017d.oasis-explorer.pages.dev/mainnet/sapphire/tx/0x9ce91f01d822bb4144de04ad4fce4711eb005c7d2824bfe38f670bf2916727ca
addr
https://dc9c017d.oasis-explorer.pages.dev/mainnet/sapphire/address/oasis1qry5d5zxs58w9deu5ara5zaamhkzqtg99s00ls90/events
block
https://dc9c017d.oasis-explorer.pages.dev/mainnet/sapphire/block/4683703/events