Set API limit when fetching data for named validators #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
approved these changes
Jan 6, 2025
1 task
buberdds
force-pushed
the
mz/validator-names-fix
branch
from
e04755f to
991ecf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change here is
limit: API_MAX_TOTAL_COUNT. Without itlimitdefaults to 100 which means we are not showing names for all validators and we are not able to find them by name.sample
TOrow, masterhttps://explorer.oasis.io/mainnet/consensus/tx/fa2ff37ed0e231ce1845d7f43b8373056907483af8bebdae116c4003d1776e79
vs
https://pr-1673.oasis-explorer.pages.dev/mainnet/consensus/tx/fa2ff37ed0e231ce1845d7f43b8373056907483af8bebdae116c4003d1776e79