Merge pull request #677 from oasisprotocol/mitjat/skip-nonexistent-block

analyzer/consensus: Skip nonexistent mainnet block 8048955

.changelog/677.bugfix.1.md

@@ -0,0 +1,4 @@
+analyzer/consensus: Skip nonexistent mainnet block 8048955
+
+Nexus can now reindex the whole range of blocks without getting stuck on this
+block.

analyzer/consensus/consensus.go

@@ -305,25 +305,27 @@ func (m *processor) ProcessBlock(ctx context.Context, uheight uint64) error {
 		return fmt.Errorf("height %d is too large", uheight)
 	}
 	height := int64(uheight)
+	batch := &storage.QueryBatch{}
 
-	// Fetch all data.
-	fetchTimer := m.metrics.BlockFetchLatencies()
-	data, err := fetchAllData(ctx, m.source, m.network, height, m.mode == analyzer.FastSyncMode)
-	fetchTimer.ObserveDuration()
-	if err != nil {
-		if strings.Contains(err.Error(), fmt.Sprintf("%d must be less than or equal to the current blockchain height", height)) {
-			return analyzer.ErrOutOfRange
+	if _, isBlockAbsent := m.history.MissingBlocks[uheight]; !isBlockAbsent {
+		// Fetch all data.
+		fetchTimer := m.metrics.BlockFetchLatencies()
+		data, err := fetchAllData(ctx, m.source, m.network, height, m.mode == analyzer.FastSyncMode)
+		fetchTimer.ObserveDuration()
+		if err != nil {
+			if strings.Contains(err.Error(), fmt.Sprintf("%d must be less than or equal to the current blockchain height", height)) {
+				return analyzer.ErrOutOfRange
+			}
+			return err
 		}
-		return err
-	}
 
-	// Process data, prepare updates.
-	analysisTimer := m.metrics.BlockAnalysisLatencies()
-	batch := &storage.QueryBatch{}
-	err = m.queueDbUpdates(batch, *data)
-	analysisTimer.ObserveDuration()
-	if err != nil {
-		return err
+		// Process data, prepare updates.
+		analysisTimer := m.metrics.BlockAnalysisLatencies()
+		err = m.queueDbUpdates(batch, *data)
+		analysisTimer.ObserveDuration()
+		if err != nil {
+			return err
+		}
 	}
 
 	// Update indexing progress.

config/history.go

@@ -23,7 +23,8 @@ type Record struct {
 }
 
 type History struct {
-	Records []*Record `koanf:"records"`
+	Records       []*Record           `koanf:"records"`
+	MissingBlocks map[uint64]struct{} `koanf:"missing_blocks"`
 }
 
 func (h *History) CurrentRecord() *Record {
@@ -82,6 +83,8 @@ func (h *History) RecordForRuntimeRound(runtime common.Runtime, round uint64) (*
 
 var DefaultChains = map[common.ChainName]*History{
 	common.ChainNameMainnet: {
+		// Block does not exist due to mishap during upgrade to Damask.
+		MissingBlocks: map[uint64]struct{}{8048955: {}},
 		Records: []*Record{
 			{
 				// https://github.com/oasisprotocol/mainnet-artifacts/releases/tag/2023-11-29
@@ -135,6 +138,7 @@ var DefaultChains = map[common.ChainName]*History{
 		},
 	},
 	common.ChainNameTestnet: {
+		MissingBlocks: map[uint64]struct{}{},
 		Records: []*Record{
 			{
 				// https://github.com/oasisprotocol/testnet-artifacts/releases/tag/2023-10-12