refactor: Simplify node client stack (remove ConsensusSourceStorage)
#554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjat
changed the title
ConsensusSourceStorageConsensusSourceStorage)
ptrus
approved these changes
Nov 3, 2023
mitjat
force-pushed
the
mitjat/remove-consensus-client
branch
2 times, most recently
from
d073e0f to
12254da
Compare
…odeApiLite and Network
mitjat
force-pushed
the
mitjat/remove-consensus-client
branch
from
12254da to
bf33bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
ConsensusSourceStorageinterface and its only implementationConsensusClient. Both of these were mostly thin wrappers aroundConsensusApiLite(with which this PR replaces them) and have been slated for removal.ConsensusClienthad methods that fell into two categories:ConsensusApiLitealready provides). These make for a lot of boilerplate, as every RPC needed to be added in at least 4 layers:ConsensusApiLite, its implemenation(s),ConsensusSourceStorage, andConsensusClient. I simply rerouted these calls directly toConsensusApiLite.AllData()and methods that it called in turn (StakingData,GovernanceData, etc). These methods rearrange data in small but convenient ways, e.g. they introduce new structs that encompass the height, epoch, and events-grouped-by-type, which makes analyzer code more streamlined and readable. It's a little verbose but not too bad. I simply moved these from thestoragemodule into the consensus analyer, and made the types private (since they are inteded strictly for analyzer's internal consumption).