analyzer: Slow-sync analyzers wait only for _relevant_ fast-sync analyzers to complete #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjat
force-pushed
the
mitjat/analyzer-sequencing
branch
2 times, most recently
from
e5c7e37 to
25b25c2
Compare
ptrus
reviewed
Nov 4, 2023
cmd/analyzer/analyzer.go
Outdated
| @@ -550,3 +586,14 @@ func Register(parentCmd *cobra.Command) { | |||
| analyzeCmd.Flags().StringVar(&configFile, "config", "./config/local.yml", "path to the config.yml file") | |||
| parentCmd.AddCommand(analyzeCmd) | |||
| } | |||
|
|
|||
| // For testing purposes only. | |||
| type ServiceTester struct { | |||
There was a problem hiding this comment.
It's also possible to move the TestSequencing test into the package analyzer (e.g. in sequencing_test.go file). Then the test will have access to package private fields directly and this workaround is not needed.
There was a problem hiding this comment.
Ah nice, thanks. Converted.
I had looked up a random existing test and figured that the separate _test package is a strong Go convention for tests. I see now that both types of testing (from mypackage_test and from mypackage) are endorsed. And sure, mypackage_test is a little cleaner, but ... not much, with my ServiceTester hack. So, not worth the hassle in this case, IMO.
ptrus
approved these changes
Nov 4, 2023
mitjat
force-pushed
the
mitjat/analyzer-sequencing
branch
from
d9a0260 to
1c01dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
fixme: slow-sync analyzers start only when all fast-sync analyzers have finished
This PR
This PR changes the sequencing of analyzers to what the title describes.
Previously, all slow-sync analyzers were started only once all fast-sync analyzers completed. But it doesn't make sense for e.eg. Sapphire to wait for fast-sync consensus to complete. These arbitrary delays were expecially noticeable when doing a full reindex (where fast-sync can take a week or more), or if one of the runtimes/consensus encountered an error during fast-sync and got stuck.