analyzer/block: more efficient db query on startup #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
approved these changes
Nov 7, 2023
| gaps AS ( | ||
| SELECT h | ||
| FROM highest_encountered_block, generate_series(GREATEST(1, $2::bigint), LEAST(highest_encountered_block.height, $3::bigint)) AS h | ||
| EXCEPT |
There was a problem hiding this comment.
ℹ️ EXCEPT them, whereas previously it fully relied on ON CONFLICT DO NOTHING
mitjat
force-pushed
the
mitjat/softEnqueueGapsInProcessedBlocks
branch
from
251c457 to
ea2fa15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
faster startup: More efficient softEnqueueGapsInProcessedBlocks()
This fn is a bottleneck during startup. It performs a very expensive SQL query. Offline experiments show that a
SELECT FROM range(...) EXCEPT SELECT ... FROM analysis.processed_blockswould be much faster.This PR
This PR speeds up a query that runs on every startup. Tested on current staging testnet (~20M rows in table): The old query takes 77s, the new query takes ~32s. Still slow, but at least better.
The PR also adds a unit test for the query, and emits a log line before running the expensive query so that logs make more sense at nexus startup time when the program apparently freezes for a bit.