-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consensus roothash messages #599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
January 6, 2024 00:44
e0a9684
to
76ba097
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
from
January 6, 2024 01:23
66c1cb2
to
b9b32be
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
January 6, 2024 01:23
76ba097
to
9a83f4c
Compare
pro-wh
commented
Jan 6, 2024
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
January 10, 2024 00:56
9a83f4c
to
b90a038
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
2 times, most recently
from
January 10, 2024 20:21
7f8dd09
to
d92613b
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
January 10, 2024 20:21
b90a038
to
9fe9dd5
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
from
January 13, 2024 00:33
d92613b
to
a3ab37b
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
January 13, 2024 00:33
9fe9dd5
to
7883149
Compare
pro-wh
commented
Jan 13, 2024
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
January 20, 2024 00:53
7883149
to
27d14ba
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
from
January 20, 2024 00:53
a3ab37b
to
84ebeff
Compare
pro-wh
commented
Jan 20, 2024
pro-wh
commented
Jan 20, 2024
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
January 26, 2024 01:23
27d14ba
to
a44da43
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
from
January 26, 2024 01:23
84ebeff
to
eeacb93
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
January 27, 2024 01:05
a44da43
to
abc164c
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
from
January 27, 2024 01:05
eeacb93
to
38f1457
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
February 1, 2024 23:34
abc164c
to
b9a78c9
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
2 times, most recently
from
February 2, 2024 22:55
2b0f121
to
bb67732
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
2 times, most recently
from
February 2, 2024 23:01
ac8733b
to
a164092
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
from
February 2, 2024 23:01
bb67732
to
20a246b
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
February 2, 2024 23:11
a164092
to
d8b99b1
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
from
February 2, 2024 23:11
20a246b
to
c0b0f1e
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
February 2, 2024 23:23
d8b99b1
to
93af0f9
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash
branch
from
February 2, 2024 23:23
c0b0f1e
to
aa5ed4c
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
February 2, 2024 23:23
93af0f9
to
b79015c
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
2 times, most recently
from
March 29, 2024 22:53
fc4c64d
to
074f83d
Compare
mitjat
reviewed
Mar 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM in general; I just have a few questions where I want to make sure the answers are not hiding surprises.
mitjat
approved these changes
Apr 2, 2024
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
3 times, most recently
from
April 9, 2024 22:28
65a053d
to
7ae4f96
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
April 10, 2024 19:46
7ae4f96
to
361f4da
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
April 10, 2024 22:20
361f4da
to
f75d720
Compare
pro-wh
force-pushed
the
pro-wh/feature/roothash2
branch
from
April 10, 2024 22:23
f75d720
to
c655ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roothash messages are small structures that a runtime can send to communicate with the consensus layer. they are agreed upon for each runtime block. we'll see the messages themselves in the proposal for that block, i.e. in the first executor commit for the round. the consensus layer processes these messages when the block gets finalized, which produces a result for each message. in cobalt and below, the roothash consensus app emits an event for each message. in damask and up, the results are stored on chain, and you use a roothash "get last round results" query to look up the results.
in this feature, we add a roothash_messages table with tracked runtimes' messages and results. either of the message or result may be absent, as they can be disseminated in different consensus blocks.