Precompute runtime account stats (total_sent, total_received) #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
reviewed
Jan 29, 2024
Andrew7234
force-pushed
the
andrew7234/account-stats
branch
from
a8e3448 to
385c196
Compare
mitjat
approved these changes
Jan 31, 2024
ptrus
approved these changes
Feb 1, 2024
Andrew7234
force-pushed
the
andrew7234/account-stats
branch
from
b8167a1 to
932be12
Compare
track total sent/received for runtime_accounts recreate index in migration nit nit query nits fix default account stats address comment
Andrew7234
force-pushed
the
andrew7234/account-stats
branch
from
932be12 to
544c041
Compare
mitjat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukaw3d noticed that a query to the runtime accounts endpoint for the fee accumulator address (https://nexus.oasis.io/v1/sapphire/accounts/oasis1qp3r8hgsnphajmfzfuaa8fhjag7e0yt35cjxq0u4) was timing out. Further investigation showed that the db operation to calculate the account statistics for
total_sentandtotal_receivedwere timing out because they were calculated on the fly and the fee accumulator account was involved in ~30% of all transfers. The query optimizer was therefore doing a full table scan onchain.runtime_transfersinstead of using the existing (flawed) index.This PR includes changes to dead-reckon the
total_sentandtotal_receivedamounts in thechain.runtime_accountstable. It also fixes the existing indexes on thechain.runtime_transferstable.