optimize daily active accounts query #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew7234
force-pushed
the
andrew7234/active-account-stats
branch
from
3e0bc2c to
7625597
Compare
pro-wh
approved these changes
Feb 1, 2024
mitjat
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
🙌
Thank you both for figuring this one out!
The biggest surprise to me (from conversation in Slack) is that with the old query, postgres was not wanting to walk the timestamp index in order to find all the blocks that belong to a specific 24h hour period. It apparently (wrongly) estimated that there will be too many such blocks. LIMIT 1 is really nice and explicit.
Andrew7234
force-pushed
the
andrew7234/active-account-stats
branch
from
7625597 to
85d1ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #862.
Query changed as suggested by @pro-wh