Add Pontus-X support #639
Merged
Add Pontus-X support #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjat
commented
Feb 13, 2024
go.mod
Outdated
| @@ -6,6 +6,7 @@ toolchain go1.21.3 | |||
|
|
|||
| replace ( | |||
| github.com/cometbft/cometbft => github.com/oasisprotocol/cometbft v0.37.2-oasis1 | |||
| github.com/oasisprotocol/oasis-sdk/client-sdk/go => /home/mitjat/oasis/oasis-sdk/client-sdk/go | |||
There was a problem hiding this comment.
PR requires https://github.com/oasisprotocol/oasis-sdk/pull/1638/files and a new SDK release, then this override can go away. In a rush, we can hardcode this part of the SDK config into nexus temporarily.
Can we use #637 for that? |
mitjat
force-pushed
the
mitjat/pontusx-support
branch
from
d9fa7a9 to
f549c34
Compare
Thanks, I prefer to do it here though so all the changes are in one PR. Commit added. |
Yeah we don't need a separate PR. As as long as your API changes are compatible, we are good. |
mitjat
force-pushed
the
mitjat/pontusx-support
branch
from
8be5020 to
9452ae7
Compare
mitjat
force-pushed
the
mitjat/pontusx-support
branch
from
9452ae7 to
5e65dc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly involves just copy-paste of all the sapphire initialization code.
I did a tiny refactor in
node_stats. Further decluttering should be possible incmd/analyzerin a future PR. But in general, the whole process was fairly painless and quick.Testing: None yet; I don't have access to a functioning node.