make evm_log_* fields null for non evm.log events #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While cleaning up the
evm_log_*
fields in #632 I noticed that these fields weren't properly set to null.evm_log_name
was set to the empty string andevm_log_signature
was set to a zero bytestring.Note: This PR does not include a migration to retroactively set existing fields to null. The queries to do this take on the order of 24hrs to run, which would be unacceptable downtime for any prod deployment. Instead, we should run the following queries manually
Testing: Manually ran the indexer and confirmed that there were no rows where
evm_log_*
was non-null for any non evm.log events.