analyzer/runtime: Deposit/Withdraw txs: make "to" explicit #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
to
field of a tx (in the DB and the API) is always populatedBackground:
For txs with method
consensus.Deposit
orconsensus.Withdraw
, theto
field in the body is optional; when omitted, the implied semantics are that the deposit/withdrawal is happening to the account of the tx sender.Nexus's
/transactions
endpoint lists txs with their raw body (where we don't want to inject the implicitto
), but also with an additionalto
field that we extract from txs regardless of the method. This PR makes it so that this field is always filled, even ifto
in the tx body is missing.Testing:
pontusx
that is known to contain a tx with an implicitto
, and verified the API response.to
, so the change is not visible there :(