common/config: move internal UNIX socket path option to config file #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/socket-config-option
branch
from
a3a2f79 to
2a58ad1
Compare
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
peternose
as code owners
kostko
approved these changes
Nov 7, 2023
Merged
peternose
reviewed
Nov 7, 2023
| @@ -75,15 +68,10 @@ func NewServerLocal(installWrapper bool) (*cmnGrpc.Server, error) { | |||
| if dataDir == "" { | |||
There was a problem hiding this comment.
Can this also be removed?
There was a problem hiding this comment.
Yeah I'll look into removing this in a follow up as this was already merged. I don't see a reason why the datadir was required here specifically - even before the change in this PR.
There was a problem hiding this comment.
I don't see a reason why the datadir was required here specifically - even before the change in this PR.
To construct the path, I guess.
There was a problem hiding this comment.
Yeah but this didn't change with the PR. It still uses the same data dir config value to construct it (unless overriden).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: backport