go/oais-node/grpc: remove unneeded datadir check #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
peternose
as code owners
ptrus
force-pushed
the
ptrus/feature/remove-datadir-check
branch
from
a6d4be6 to
9e06c53
Compare
kostko
approved these changes
Nov 7, 2023
peternose
approved these changes
Nov 7, 2023
ptrus
force-pushed
the
ptrus/feature/remove-datadir-check
branch
from
9e06c53 to
5ff38a7
Compare
ptrus
force-pushed
the
ptrus/feature/remove-datadir-check
branch
from
5ff38a7 to
7f64f6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason to check for non-empty datadir here specifically. On node init it is already checked in:
oasis-core/go/oasis-node/cmd/node/node.go
Line 473 in 12e86f1