Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofl-containers: Also expose secrets via env file #2137

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 22, 2025

No description provided.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for oasisprotocol-oasis-sdk canceled.

Name Link
🔨 Latest commit f02e8c3
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/6790d2fee2853a0008080d20

@kostko kostko force-pushed the kostko/feature/rofl-secrets-env-meta branch from 0e460a6 to 5cf88fb Compare January 22, 2025 10:59
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (5e0e6a9) to head (5cf88fb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
runtime-sdk/src/modules/rofl/app/registration.rs 0.00% 5 Missing ⚠️
rofl-containers/src/containers.rs 0.00% 4 Missing ⚠️
rofl-containers/src/secrets.rs 0.00% 4 Missing ⚠️
runtime-sdk/src/modules/rofl/app/mod.rs 0.00% 1 Missing ⚠️
runtime-sdk/src/modules/rofl/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2137      +/-   ##
==========================================
- Coverage   58.48%   57.96%   -0.53%     
==========================================
  Files         139      141       +2     
  Lines        9941    10031      +90     
==========================================
  Hits         5814     5814              
- Misses       4127     4217      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kostko kostko force-pushed the kostko/feature/rofl-secrets-env-meta branch from 5cf88fb to f02e8c3 Compare January 22, 2025 11:14
@kostko kostko enabled auto-merge January 22, 2025 11:14
@kostko kostko merged commit 142a792 into main Jan 22, 2025
26 checks passed
@kostko kostko deleted the kostko/feature/rofl-secrets-env-meta branch January 22, 2025 11:38
github-actions bot added a commit that referenced this pull request Jan 22, 2025
…ostko/feature/rofl-secrets-env-meta

rofl-containers: Also expose secrets via env file 142a792
github-actions bot added a commit that referenced this pull request Jan 22, 2025
…/kostko/feature/rofl-secrets-env-meta

rofl-containers: Also expose secrets via env file 142a792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants