docker: Rename emerald and sapphire -dev to -localnet #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
force-pushed
the
matevz/docker/rename-to-localnet
branch
from
8d2e6e2 to
5a3b567
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 62.33% 62.33%
=======================================
Files 37 37
Lines 3921 3921
=======================================
Hits 2444 2444
Misses 1272 1272
Partials 205 205 ☔ View full report in Codecov by Sentry. |
matevz
force-pushed
the
matevz/docker/rename-to-localnet
branch
from
5a3b567 to
a59de28
Compare
matevz
force-pushed
the
matevz/docker/rename-to-localnet
branch
3 times, most recently
from
5ec0611 to
757bf6c
Compare
matevz
force-pushed
the
matevz/docker/rename-to-localnet
branch
from
757bf6c to
2949d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
-devsuffix to name the docker images that provide the compilation environment for the oasis-core, the key manager and similar. The-devsuffix for emerald and sapphire was picked before we started using the Localnet term more broadly, specific chain IDs etc. This PR renames the emerald and sapphire docker images running Localnet fromemerald-devandsapphire-devtoemerald-localnetandsapphire-localnetrespectively to better reflect the actual usage.