[INF-227] Enforce correct response value complies with base type #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirylHatalski
requested review from
Karol-Stelmaczonek and
viktar-dzmitryieu-tao
views/js/qtiCreator/widgets/interactions/textEntryInteraction/states/Correct.js
Outdated
Show resolved
Hide resolved
viktar-dzmitryieu-tao
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
andreluizmachado
approved these changes
Jan 16, 2024
Front-end summary Node 18
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2433 +/- ##
==========================================
Coverage 16.07% 16.07%
Complexity 4207 4207
==========================================
Files 391 391
Lines 13486 13486
==========================================
Hits 2168 2168
Misses 11318 11318 ☔ View full report in Codecov by Sentry. |
added 5 commits
January 24, 2024 17:17
viktar-dzmitryieu-tao
approved these changes
Jan 30, 2024
Version
There are 0 BREAKING CHANGE, 0 feature, 16 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: INF-227
What's Changed
Demo
How to test
Kitchen