Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/BSA-391/Feature flags doesn't exist in unit tests #2434

Merged

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Jan 16, 2024

Related to: https://oat-sa.atlassian.net/browse/BSA-391

Summary

Fix unit tests falling because the collection of feature flags is not set to the unit test through the context.

How to test

run the unit tests (check the CI)

@jsconan jsconan requested review from erkobridee and shaveko January 16, 2024 14:38
Copy link

Version

Target Version 30.5.2
Last version 30.5.1

There are 0 BREAKING CHANGE, 0 feature, 1 fix

Copy link

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
281 281 0 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ea6f4f) 16.07% compared to head (7b2f825) 16.07%.
Report is 12 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2434   +/-   ##
==========================================
  Coverage      16.07%   16.07%           
  Complexity      4207     4207           
==========================================
  Files            391      391           
  Lines          13486    13486           
==========================================
  Hits            2168     2168           
  Misses         11318    11318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andreluizmachado andreluizmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsconan jsconan merged commit dd97b65 into develop Jan 17, 2024
5 of 6 checks passed
@jsconan jsconan deleted the fix/BSA-391/feature-flags-doesnt-exist-in-unit-tests branch January 17, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants