Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/AUT-3960/GapMatchinteraction ckeditor console error on image wrap #608

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

olga-kulish
Copy link
Contributor

@olga-kulish olga-kulish commented Nov 14, 2024

Related to https://oat-sa.atlassian.net/browse/AUT-3960

Add image to the body of HotText/GapMatch or to ChoiceInteraction's Choice, wrap it --> there's ckEditor error in console on widget.element.bdy.rootElement because widget.element.bdy doesn't exist.
This console error is harmless but let's get rid of it.

To test

On unit01. All PRs:

@olga-kulish olga-kulish changed the title fix: gapmatch/hottext/choice: image wrap: ckeditor console error Fix/AUT-3960/gapmatch hottext choice - ckeditor console error on image wrap Nov 15, 2024
@olga-kulish olga-kulish changed the title Fix/AUT-3960/gapmatch hottext choice - ckeditor console error on image wrap Fix/AUT-3960/gapmatch - ckeditor console error on image wrap Nov 15, 2024
@olga-kulish olga-kulish changed the title Fix/AUT-3960/gapmatch - ckeditor console error on image wrap Fix/AUT-3960/GapMatchinteraction ckeditor console error on image wrap Nov 15, 2024
@olga-kulish olga-kulish changed the base branch from master to develop November 15, 2024 13:44
@olga-kulish olga-kulish requested review from a team, oatymart and taopkorczak November 15, 2024 14:51
Copy link
Contributor

@oatymart oatymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olga-kulish olga-kulish merged commit 89b2fdd into develop Dec 9, 2024
@olga-kulish olga-kulish deleted the fix/AUT-3960/gapmatch-cant-remove-asset branch December 9, 2024 08:22
@olga-kulish olga-kulish mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants