Fix/rel 1418/fix phpdoc blocking cache warmup #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
vbyndych
approved these changes
Jan 15, 2024
Co-authored-by: Vlad Byndych <[email protected]> Signed-off-by: Augustas <[email protected]>
Version❕ Some commits are not using the conventional commits formats. They will be ignored in version management.
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
yaraslau-kavaliou
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
- New code is covered by tests
- Tests are running successfully on my local machine
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not master
- Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a phpdoc block that prevents cache warmup.
Related to : https://oat-sa.atlassian.net/browse/REL-985
Without the fix, phpdoc parser throws an error like:
Steps to reproduce (for bugs)
php index.php 'oat\generis\scripts\tools\ApplicationCacheWarmup'Cache warmup failed: Unexpected token "{", expected type at offset 0 on line 1How to test
To test, run the cache warmup command and get the
TAO cache warmed up!report.