Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ADF-1752/Confirm category propagation #4079

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Jul 26, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1752

Summary

Set the correct style to the tags in a selec2 selector when a partial representation is declared.

Details

When a tag applies to a part only of the contained items, it must have a style that reflects this state.

With the legacy theme, this is the case. But with the Solar UI, it was not applied.

  • Legacy
    image

  • Solar UI

    • before:
      image
    • after
      image

How to test

  • checkout the branch: git checkout -t origin/feature/ADF-1752/confirm-category-propagation
  • open TAO backoffice, then author a test with multiple items in it
  • set a custom category to a test part or a section
  • from an item, remove the category
  • go back to the test part or section and see the style
  • check with and without the Solar UI style (can be made by setting and removing the class solar-design on the body tag)

Copy link

github-actions bot commented Jul 26, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
161 161 0 0

Copy link
Contributor

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

jsconan added 2 commits July 29, 2024 12:42
…tion

 Conflicts:
	views/css/tao-main-style.css
	views/css/tao-main-style.css.map
	views/js/lib/jsTree/themes/css/style.css.map
Copy link

Version

Target Version 54.17.2
Last version 54.17.1

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@jsconan jsconan merged commit f4791ce into develop Jul 31, 2024
6 checks passed
@jsconan jsconan deleted the feature/ADF-1752/confirm-category-propagation branch July 31, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants