Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add existing instance check #4145

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Conversation

Nevermind23
Copy link
Contributor

Tasks

https://oat-sa.atlassian.net/browse/ADF-1825

Changelog

  • Add existing check before deleting instances

Copy link

github-actions bot commented Dec 5, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
241 241 0 0

Copy link

github-actions bot commented Dec 5, 2024

Version

Target Version 54.26.2
Last version 54.26.1

There are 0 BREAKING CHANGE, 0 feature, 6 fixes

Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nevermind23

Sounds like a clean solution!

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@gabrielfs7 gabrielfs7 merged commit dc3374a into develop Dec 11, 2024
6 checks passed
@gabrielfs7 gabrielfs7 deleted the fix/ADF-1825/add-existing-check branch December 11, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants