Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: booklet download from tasks queue #4154

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

viktar-dzmitryieu-tao
Copy link
Contributor

Ticket: https://oat-sa.atlassian.net/browse/LSI-5002

What's Changed

  • Fixed the issue when user is not able to download the PDF generated from booklet

How to test

  • In the Tests tab, select a test
  • Click “New booklet” button
  • Click “Generate”
  • In the Background tasks, find the task with generated booklet
  • Click “Download” icon
  • The booklet should be downloaded successfully

@@ -13,7 +13,7 @@
"@oat-sa/tao-core-libs": "^1.0.0",
"@oat-sa/tao-core-sdk": "^3.2.1",
"@oat-sa/tao-core-shared-libs": "^1.6.1",
"@oat-sa/tao-core-ui": "^3.9.1",
"@oat-sa/tao-core-ui": "git://github.com/oat-sa/tao-core-ui-fe#fix/LSI-5002/booklet-download",
Copy link
Contributor Author

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • update to stable version once tested

Copy link

github-actions bot commented Dec 16, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
241 241 0 0

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao requested review from a team, tikhanovichA, KirylHatalski and Karol-Stelmaczonek and removed request for a team December 17, 2024 10:59
Copy link

Version

Target Version 54.28.4
Last version 54.28.3

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao merged commit 06a8d1c into develop Dec 19, 2024
6 checks passed
@viktar-dzmitryieu-tao viktar-dzmitryieu-tao deleted the fix/LSI-5002/booklet-download branch December 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants