fix: connection urls to be automatically comma separated #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pierluigilenoci I think the new test case is broken. Will quickly check tomorrow. I have a bad connection right now and cannot fetch the redis helm chart -.- |
tuunit
force-pushed
the
fix-connection-urls-syntax
branch
from
4ce8e98 to
cb59386
Compare
|
@tuunit, this is a breaking change. |
This is not a breaking change!! |
tuunit
force-pushed
the
fix-connection-urls-syntax
branch
3 times, most recently
from
9276904 to
0a6c1a0
Compare
tuunit
force-pushed
the
fix-connection-urls-syntax
branch
from
0a6c1a0 to
adf5843
Compare
|
@tuunit, do you have any chances to move forward with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
connectionUrlsattribute ofsessionStorage.redis.clusterandsessionStorage.redis.sentinelis currently of type array which doesn't work.Solution
Add
join ","to the templating to automatically generate a comma separated string and allow for single string values as well.