Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink license file to each crate directory #734

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

michel-slm
Copy link
Contributor

This allows them to be picked up by cargo package so the license text is included in the distributed crate.

trustfall on  add-license via 🦀 v1.80.1
⬢ [fedora-packaging] ❯ for crate in trustfall*; cd $crate; echo $crate; cargo package --list | grep LICENSE.txt; cd -; end
trustfall
    Updating crates.io index
LICENSE.txt
trustfall_core
LICENSE.txt
trustfall_derive
LICENSE.txt
trustfall_filetests_macros
LICENSE.txt
trustfall_stubgen
warning: readme `../README.md` appears to be a path outside of the package, but there is already a file named `README.md` in the root of the package. The archived crate will contain the copy in the root of the package. Update the readme to point to the path relative to the root of the package to remove this warning.
LICENSE.txt
trustfall_testbin
warning: manifest has no description, license, license-file, documentation, homepage or repository.
See https://doc.rust-lang.org/cargo/reference/manifest.html#package-metadata for more info.
LICENSE.txt
trustfall_wasm
warning: manifest has no description, license, license-file, documentation, homepage or repository.
See https://doc.rust-lang.org/cargo/reference/manifest.html#package-metadata for more info.
LICENSE.txt

This allows them to be picked up by `cargo package` so the license text
is included in the distributed crate.

```
trustfall on  add-license via 🦀 v1.80.1
⬢ [fedora-packaging] ❯ for crate in trustfall*; cd $crate; echo $crate; cargo package --list | grep LICENSE.txt; cd -; end
trustfall
    Updating crates.io index
LICENSE.txt
trustfall_core
LICENSE.txt
trustfall_derive
LICENSE.txt
trustfall_filetests_macros
LICENSE.txt
trustfall_stubgen
warning: readme `../README.md` appears to be a path outside of the package, but there is already a file named `README.md` in the root of the package. The archived crate will contain the copy in the root of the package. Update the readme to point to the path relative to the root of the package to remove this warning.
LICENSE.txt
trustfall_testbin
warning: manifest has no description, license, license-file, documentation, homepage or repository.
See https://doc.rust-lang.org/cargo/reference/manifest.html#package-metadata for more info.
LICENSE.txt
trustfall_wasm
warning: manifest has no description, license, license-file, documentation, homepage or repository.
See https://doc.rust-lang.org/cargo/reference/manifest.html#package-metadata for more info.
LICENSE.txt
```

Signed-off-by: Michel Lind <[email protected]>
@obi1kenobi
Copy link
Owner

Nice, thank you for the fix! If you don't mind me asking, how did you notice this issue? I'm quite curious :)

@obi1kenobi obi1kenobi enabled auto-merge (squash) January 29, 2025 14:58
@obi1kenobi obi1kenobi merged commit a13173b into obi1kenobi:main Jan 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants