Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor launch package #108

Closed
c71n93 opened this issue Mar 9, 2023 · 4 comments
Closed

Refactor launch package #108

c71n93 opened this issue Mar 9, 2023 · 4 comments

Comments

@c71n93
Copy link
Member

c71n93 commented Mar 9, 2023

Before adding some functionality to aoi (objectionary/aoi#39, objectionary/aoi#40, objectionary/aoi#41) most of the code needs to be refactored here. First of all launch package need to be refactored.

Here:

private val logger = LoggerFactory.getLogger("org.objectionary.ddr.launch.Combiner")
private val sep = File.separatorChar
val documents: MutableMap<Document, String> = mutableMapOf()

global variables are defined. documents variable is modified in functions launch and buildGraph. Then documents is used throughout the program, and also in aoi.

The functions themselves here also do too much, so decomposition is broken. I think this code should be made more object-oriented. @yegor256, @mximp, WDYT?

@mximp
Copy link

mximp commented Mar 9, 2023

@c71n93 I agree. Go ahead.

@0pdd
Copy link

0pdd commented Mar 16, 2023

@c71n93 the puzzle #111 is still not solved.

@0pdd
Copy link

0pdd commented Apr 21, 2023

@c71n93 the puzzle #113 is still not solved; solved: #111.

@0pdd
Copy link

0pdd commented May 3, 2023

@c71n93 all 2 puzzles are solved here: #111, #113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants