-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor launch package #108
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before adding some functionality to aoi (objectionary/aoi#39, objectionary/aoi#40, objectionary/aoi#41) most of the code needs to be refactored here. First of all
launch
package need to be refactored.Here:
ddr/src/main/kotlin/org/objectionary/ddr/launch/Combiner.kt
Lines 43 to 45 in 7a013e8
global variables are defined.
documents
variable is modified in functionslaunch
andbuildGraph
. Thendocuments
is used throughout the program, and also in aoi.The functions themselves here also do too much, so decomposition is broken. I think this code should be made more object-oriented. @yegor256, @mximp, WDYT?
The text was updated successfully, but these errors were encountered: