Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ddr.launch package #110

Merged
merged 12 commits into from
Mar 16, 2023
Merged

Refactor ddr.launch package #110

merged 12 commits into from
Mar 16, 2023

Conversation

c71n93
Copy link
Member

@c71n93 c71n93 commented Mar 10, 2023

Related to #108. Here I implemented class SourcesDdr. The class that will run the program, I will implement in the following PR (todo)

@c71n93 c71n93 changed the title Refactor launch file Refactor launch package Mar 10, 2023
@c71n93 c71n93 changed the title Refactor launch package Refactor org.objectionary.ddr.launch package Mar 10, 2023
@c71n93 c71n93 changed the title Refactor org.objectionary.ddr.launch package Refactor ddr.launch package Mar 10, 2023
@c71n93
Copy link
Member Author

c71n93 commented Mar 10, 2023

@mximp, could you review please?

@c71n93
Copy link
Member Author

c71n93 commented Mar 16, 2023

@mximp could you please check resolved comments?

@c71n93
Copy link
Member Author

c71n93 commented Mar 16, 2023

@yegor256 take a look please

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 16, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 859549b into objectionary:master Mar 16, 2023
@rultor
Copy link
Contributor

rultor commented Mar 16, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min)

@c71n93 c71n93 deleted the 108-refactor-launch branch September 24, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants