-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(#3845): introduced roll-bases.xsl
#3867
bug(#3845): introduced roll-bases.xsl
#3867
Conversation
@yegor256 please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon this is a massive change, thanks! One question though, about DiscoverMojo
. Can't we keep the test intact?
eo-maven-plugin/src/test/java/org/eolang/maven/DiscoverMojoTest.java
Outdated
Show resolved
Hide resolved
@yegor256 I disabled the test because it just does not work with new composite bases. Also we don't need this mojo anymore, it kind of duplicates the functionality of |
@maxonfjvipon yes, just delete it and its test |
@yegor256 done, please check one more time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon cool, thanks a lot!
Closes: #3845
In this PR I introduced
roll-bases.xsl
and made it a part of canonical EO and PHI parsing pipelines.It required:
TrShaking
and moving many XSLs from it to EoSyntax and PhiSyntaxadd-probes.xsl
. It led to removingDiscoverMojo
fromassemble
pipelineNow we have:
3.1. either
∅
3.2. or start with
.
3.3. or start with
Q
3.4. or start with
$
all other options are prohibited by XSD