Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#3845): introduced roll-bases.xsl #3867

Merged
merged 13 commits into from
Jan 29, 2025

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jan 29, 2025

Closes: #3845

In this PR I introduced roll-bases.xsl and made it a part of canonical EO and PHI parsing pipelines.
It required:

  1. Refactoring TrShaking and moving many XSLs from it to EoSyntax and PhiSyntax
  2. Refactoring add-probes.xsl. It led to removing DiscoverMojo from assemble pipeline
  3. Refactoring converting XMIR to PHI and to EO
  4. Refactoring many yaml test packs
  5. Fixing converting to Java
  6. Suppressing many lints in eo-runtime

Now we have:

  1. We can get canonical XMIR right after EO or PHI parsing
  2. Objects bases in such XMIR must be:
    3.1. either
    3.2. or start with .
    3.3. or start with Q
    3.4. or start with $
    all other options are prohibited by XSD
  3. all object bases must be rolled into single one until it's not possible anymore
  4. canonical XMIR now also assumes that we have named objects only at the first level of abstract objects

@github-actions github-actions bot added the core label Jan 29, 2025
@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon this is a massive change, thanks! One question though, about DiscoverMojo. Can't we keep the test intact?

@maxonfjvipon
Copy link
Member Author

maxonfjvipon commented Jan 29, 2025

@yegor256 I disabled the test because it just does not work with new composite bases. Also we don't need this mojo anymore, it kind of duplicates the functionality of add-probes.xsl and ProbeMojo. That's why it was removed from assemble pipeline. So I can just delete the mojo and the test. WDYT?

@yegor256
Copy link
Member

@maxonfjvipon yes, just delete it and its test

@maxonfjvipon
Copy link
Member Author

@yegor256 done, please check one more time

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon cool, thanks a lot!

@yegor256 yegor256 enabled auto-merge January 29, 2025 18:44
@yegor256 yegor256 added this pull request to the merge queue Jan 29, 2025
Merged via the queue into objectionary:master with commit 710f776 Jan 29, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roll bases if possible
2 participants