-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the @name
attribute seems to be redundant
#923
Comments
@volodya-lombrozo check this out please |
@yegor256 I will check it, thank you. |
….xsl, and vars-float-down.xsl
@volodya-lombrozo I don't see the logs of failure in the PR :( |
@yegor256 Here is the failed pipeline: https://github.com/objectionary/jeo-maven-plugin/actions/runs/12135454483/job/33834545174?pr=935 As you can see, the
Here are logs from the By using the following link you may download the failed pipeline folders (and find exact files that were created during all phases): https://github.com/objectionary/jeo-maven-plugin/actions/runs/12135454483/artifacts/2265953649 Long story short, I'm getting something like: Caused by: java.lang.IllegalArgumentException: Annotation [o: null] has no child at index 0
at org.eolang.jeo.representation.xmir.XmlAnnotation.child (XmlAnnotation.java:99)
at org.eolang.jeo.representation.xmir.XmlAnnotation.descriptor (XmlAnnotation.java:78)
at org.eolang.jeo.representation.xmir.XmlAnnotation.bytecode (XmlAnnotation.java:58)
at java.util.stream.ReferencePipeline$3$1.accept (ReferencePipeline.java:195)
at java.util.ArrayList$ArrayListSpliterator.forEachRemaining (ArrayList.java:1655)
at java.util.stream.AbstractPipeline.copyInto (AbstractPipeline.java:484)
at java.util.stream.AbstractPipeline.wrapAndCopyInto (AbstractPipeline.java:474)
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential (ReduceOps.java:913)
at java.util.stream.AbstractPipeline.evaluate (AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect (ReferencePipeline.java:578)
at org.eolang.jeo.representation.bytecode.BytecodeAnnotations.<init> (BytecodeAnnotations.java:61)
at org.eolang.jeo.representation.xmir.XmlAnnotations.bytecode (XmlAnnotations.java:54)
at java.util.Optional.map (Optional.java:265) It means, that |
@volodya-lombrozo thanks! |
This is what I see in XMIR after jeo:disassemble:
Here, I believe, you may stop using
@name
attribute, since you have all necessary information in the@base
-- you know the name of the opcode.If you remove
@name
, you can remove three XSL from the unroll procedure:add-cuts.xsl
,remove-cuts.xsl
, andvars-float-down.xsl
.The text was updated successfully, but these errors were encountered: