Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanonicalXmir.java:139-144: Do we need all the... #936

Closed
0pdd opened this issue Dec 3, 2024 · 0 comments · Fixed by #998
Closed

CanonicalXmir.java:139-144: Do we need all the... #936

0pdd opened this issue Dec 3, 2024 · 0 comments · Fixed by #998
Assignees
@volodya-lombrozo
Labels
bug Something isn't working

Comments

@0pdd
Copy link

0pdd commented Dec 3, 2024

The puzzle 923-366c7448 from #923 has to be resolved:

jeo-maven-plugin/src/main/java/org/eolang/jeo/representation/CanonicalXmir.java

Lines 139 to 144 in db7f5ea

* @todo #923:30min Do we need all the transformations in the unroll method?
* Most probably, some of the steps might be skipped and removed from the unroll method.
* We need to investigate which steps are necessary and which are not.
* This issue implies that it's possible:
* https://github.com/objectionary/jeo-maven-plugin/issues/923
* At least for add-cuts.xsl, remove-cuts.xsl, and vars-float-down.xsl.

The puzzle was created by volodya-lombrozo on 03-Dec-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Dec 3, 2024
@volodya-lombrozo
feat(#923): fix all the code offences
db7f5ea
@0pdd 0pdd mentioned this issue Dec 3, 2024
Closed
@volodya-lombrozo volodya-lombrozo self-assigned this Feb 12, 2025
@volodya-lombrozo volodya-lombrozo added the bug Something isn't working label Feb 12, 2025
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Feb 12, 2025
@volodya-lombrozo
feat(objectionary#936): upgrade eo version '0.51.2' -> '0.51.4' since…
d3c30a1 
… some of the places still had the old version
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Feb 12, 2025
@volodya-lombrozo
feat(objectionary#936): remove unrolling from 'phi-unphi' integration…
b1e6244 
… test
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Feb 12, 2025
@volodya-lombrozo
feat(objectionary#936): remove unrolling from 'jna' integraton test
83116ab
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Feb 12, 2025
@volodya-lombrozo
feat(objectionary#936): remove all the mentions of 'unrolling' from i…
0099c41 
…ntegration tests
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Feb 12, 2025
@volodya-lombrozo
feat(objectionary#936): remove all the classes related to unrolling
7293160
@volodya-lombrozo volodya-lombrozo mentioned this issue Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volodya-lombrozo volodya-lombrozo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#936): Remove UnrollMojo volodya-lombrozo/jeo-maven-plugin
2 participants
@0pdd @volodya-lombrozo