Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#89): refactor asm related classes #94

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Sep 26, 2023

Move asm related classes into separate package
Closes: #89


PR-Codex overview

This PR focuses on refactoring and adding functionality to the org.eolang.jeo.representation.asm package.

Detailed summary

  • Moved OpcodeName class to org.eolang.jeo.representation.asm package.
  • Added ClassName class to extract the class name from bytecode.
  • Added MethodDirectives class to build Xembly directives for methods.
  • Added ClassDirectives class to build Xembly directives for classes.

The following files were skipped due to too many changes: src/main/java/org/eolang/jeo/representation/asm/ClassDirectives.java, src/main/java/org/eolang/jeo/representation/BytecodeRepresentation.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Sep 26, 2023

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b52e162 into objectionary:master Sep 26, 2023
@rultor
Copy link
Contributor

rultor commented Sep 26, 2023

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BytecodeRepresentation.java:56-60: Refactor...
3 participants