Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#268): test for EO application-duality false alarm #271

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

h1alexbel
Copy link
Contributor

In this PR I've added test that proves the work of application-duality lint with EO test case

see #268

@h1alexbel
Copy link
Contributor Author

h1alexbel commented Jan 22, 2025

@yegor256 This snippet does not warn about application duality:

# Foo.
[] > foo
  a > @
    "first".as-bytes:0
    "second":1

Maybe I missing something here?

@yegor256 yegor256 merged commit acc2afe into objectionary:master Jan 22, 2025
14 of 15 checks passed
@h1alexbel h1alexbel deleted the 268 branch January 22, 2025 14:35
@0crat
Copy link

0crat commented Jan 23, 2025

@h1alexbel Thank you for your contribution! Your effort is appreciated, but there are areas for improvement. You've earned +4 points: +4 as a base, -16 for no code review, -4 for insufficient comments (only 1), and +20 to maintain the minimum reward. Please note that code reviews and constructive comments are crucial for our team's success. We encourage you to focus on quality in future contributions. Your current balance stands at +61. Keep up the good work and remember to engage in the review process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants