-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(#268): allow vertical-bound-method in application-duality
#280
Conversation
application-duality
@maxonfjvipon please check this one. I'm not sure if my fix is right. Would like to hear your feedback |
<xsl:if test="count(o) != count(o[@as]) and count(o) != count(o[not(@as)])"> | ||
<xsl:variable name="violates" as="xs:boolean"> | ||
<xsl:choose> | ||
<xsl:when test="starts-with(@base, '.')"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel let's simplify all of this with something like:
<xsl:variable name="args">
<xsl:choose>
<xsl:when test="starts-with(@base, '.')">
<xsl:value-of select="o[position()>1]"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="o"/>
</xsl:otherwise>
</xsl:choose>
</xsl:variable>
<xsl:if test="count($args) != count($args[@as]) and count($args) != count($args[not(@as)])"/>
@maxonfjvipon updated. Take a look, please |
@yegor256 take a look, please |
@h1alexbel thanks! |
@maxonfjvipon Thanks for the review! Here's your reward breakdown: +4 base points, -24 for self-review, +1.6 for 160 hits-of-code, -10 for only 5 comments, +1.25 for those comments. Total: 4 points (min. reward). Your balance is now +27. Keep up the good work and aim for more comments next time! 💪 |
In this PR I've updated
application-duality
lint to handle@as
references in vertical and horizontal method bounds.see #268
History:
application-duality
false alarm #268): skip firstapplication-duality
false alarm #268): count(as) not 0