Correction impossibilité de donner une nouvelle localisation à un secteur #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :default-latitude="data.latitude || crag.latitude" | ||
| :default-longitude="data.longitude || crag.longitude" | ||
| :default-latitude="data.latitude" | ||
| :default-longitude="data.longitude" |
There was a problem hiding this comment.
En fait si on fait ça, par défaut le marquer sera quelque part vers Nevers (~ centre de la France)
Par contre il y a un bug quand on passe le "crag'" au CragSectorForm
Ce que je te propose, c'est dans ce fichier :
pages/crags/_cragId/_cragName/sectors/_cragSectorId/_cragSectorName/edit.vue
Au niveau du composant on donne le crag qui est dans le crag_sector
<crag-sector-form
:crag="cragSector.crag"
:crag-sector="cragSector"
submit-methode="put"
/>Et du coup on peut supprimer l'import de CragConcern
Ça économisera une requête à l'api en plus : )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En lien avec #52
Le map-input de CragSectorForm cherchait à utiliser crag.latitude si data.latitude n'existait pas. Cependant, crag était nul. Ce changement retire crag.latitude et crag.longitude et laisse à map-input la gestion des valeurs nulles.