chore: remove lazy-hydrate #97
Closed
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghusse
force-pushed
the
chore/lazy-hydrate
branch
from
7100077
to
b11ab0b
Compare
|
Ok, j'ai fait une erreur avec le merge de master sur cette branche. Mais je viens de m'apercevoir que c'était bel et bien utilisé sur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette dépendance ne semble pas être utilisée (il faut utiliser le composant
<LazyHydrate>pour que ça ait un effet, du moins c'est ce que je comprends).Cette dépendance est en version bêta dans le package.json, et elle semble ne pas avoir été modifiée depuis au moins 4 ans, ce qui laisse penser qu'elle risque de poser souci pour les mises à jour.
La PR #96 doit être mergée d'abord car elle contient des modifications sur le package-lock qui sont aussi incluses dans cette PR (si je ne le fais pas, dans tous les cas il y aura un conflit lors du merge de la première).