Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2671 - Clean up squamous epithelial cell and subclasses #2962

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

Caroline-99
Copy link
Collaborator

Fixes #2671 -

Squamous epithelial cell and subclasses

Fixes #2671 -

Squamous epithelial cell and subclasses
@Caroline-99 Caroline-99 linked an issue Feb 12, 2025 that may be closed by this pull request
@Caroline-99 Caroline-99 self-assigned this Feb 12, 2025
@Caroline-99
Copy link
Collaborator Author

#gogoeditdiff

Copy link

github-actions bot commented Feb 12, 2025

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-02-24/cl-base.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-master.owl/cl-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-02-24/cl-base.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-pr.owl/cl-base.owl

Ontology imports

Ontology annotations

Caenorhabditis hypodermal cell http://purl.obolibrary.org/obo/CL_0000411

Removed

Added

PATO_0001872 http://purl.obolibrary.org/obo/PATO_0001872

Added

UBERON_0003055 http://purl.obolibrary.org/obo/UBERON_0003055

Added

UBERON_0006914 http://purl.obolibrary.org/obo/UBERON_0006914

Removed

conjunctiva goblet cell http://purl.obolibrary.org/obo/CL_2000084

Removed

gingival epithelial cell http://purl.obolibrary.org/obo/CL_0002621

Removed

Added

parietal epithelial cell http://purl.obolibrary.org/obo/CL_1000452

Removed

peridermal cell http://purl.obolibrary.org/obo/CL_0000078

Removed

Added

pulmonary alveolar epithelial cell http://purl.obolibrary.org/obo/CL_0000322

Removed

pulmonary alveolar type 1 cell http://purl.obolibrary.org/obo/CL_0002062

Added

pulmonary alveolar type 2 cell http://purl.obolibrary.org/obo/CL_0002063

Added

squamous epithelial cell http://purl.obolibrary.org/obo/CL_0000076

Removed

type A synovial cell http://purl.obolibrary.org/obo/CL_0002302

Removed

type B synovial cell http://purl.obolibrary.org/obo/CL_0002301

Removed

Copy link

github-actions bot commented Feb 12, 2025

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl-edit.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl-edit.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

Caenorhabditis hypodermal cell http://purl.obolibrary.org/obo/CL_0000411

Removed

Added

cuboid http://purl.obolibrary.org/obo/PATO_0001872

Added

gingival epithelial cell http://purl.obolibrary.org/obo/CL_0002621

Removed

Added

kidney loop of Henle short descending thin limb epithelial cell http://purl.obolibrary.org/obo/CL_4030012

Added

peridermal cell http://purl.obolibrary.org/obo/CL_0000078

Removed

Added

pulmonary alveolar type 1 cell http://purl.obolibrary.org/obo/CL_0002062

Added

pulmonary alveolar type 2 cell http://purl.obolibrary.org/obo/CL_0002063

Removed

Added

squamous epithelial cell http://purl.obolibrary.org/obo/CL_0000076

Removed

Added

stratified squamous epithelial cell http://purl.obolibrary.org/obo/CL_0000240

Added

@Caroline-99 Caroline-99 marked this pull request as draft February 12, 2025 16:11
@Caroline-99 Caroline-99 marked this pull request as ready for review February 24, 2025 13:50
@Caroline-99
Copy link
Collaborator Author

#gogoeditdiff

@dosumis
Copy link
Contributor

dosumis commented Feb 25, 2025

Looks like peridermal cells are squamous:

From Perplexity search

Peridermal cells in the context of embryology are squamous. During embryogenesis, the immature ectoderm initially consists of cuboidal epithelial cells, which stratify to form a superficial layer of flattened, squamous-like peridermal cells. These cells are described as flattened and endothelial-like, covering the developing epithelia as a single layer throughout much of embryonic development before being shed or replaced by terminally differentiated keratinocytes later in development123.

This squamous morphology allows peridermal cells to act as a protective barrier, preventing pathological adhesions between epithelial surfaces during critical stages of development24.

Everything else looks good to me

@Caroline-99
Copy link
Collaborator Author

Looks like peridermal cells are squamous:

From Perplexity search

Peridermal cells in the context of embryology are squamous. During embryogenesis, the immature ectoderm initially consists of cuboidal epithelial cells, which stratify to form a superficial layer of flattened, squamous-like peridermal cells. These cells are described as flattened and endothelial-like, covering the developing epithelia as a single layer throughout much of embryonic development before being shed or replaced by terminally differentiated keratinocytes later in development123.
This squamous morphology allows peridermal cells to act as a protective barrier, preventing pathological adhesions between epithelial surfaces during critical stages of development24.

Everything else looks good to me

I have checked the references provided by perplexity and updated periderm cell's logical defs. I have also double checked the references for kidney loop of Henle short descending thin limb epithelial cell

@Caroline-99 Caroline-99 merged commit 5928062 into master Feb 25, 2025
1 check passed
@Caroline-99 Caroline-99 deleted the 2671-squamous-epithelial-cell---update-ec-def branch February 25, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Squamous epithelial cell - update EC def
2 participants