fix: don't include tools for empty knowledge sets

Signed-off-by: Donnie Adams <[email protected]>
obot-platform · Oct 22, 2024 · 27e8163 · 27e8163
1 parent 5e4d6d5
commit 27e8163
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/pkg/controller/handlers/knowledgeset/knowledgeset.go b/pkg/controller/handlers/knowledgeset/knowledgeset.go
@@ -54,6 +54,7 @@ func (h *Handler) GenerateDataDescription(req router.Request, resp router.Respon
 	}
 
 	if len(files.Items) == 0 {
+		ks.Status.IsEmpty = true
 		return nil
 	}
 

diff --git a/pkg/render/render.go b/pkg/render/render.go
@@ -154,7 +154,7 @@ func addKnowledgeTools(ctx context.Context, db kclient.Client, agent *v1.Agent,
 			dataDescription = ks.Status.SuggestedDataDescription
 		}
 
-		if dataDescription == "" {
+		if ks.Status.IsEmpty || dataDescription == "" {
 			continue
 		}
 

diff --git a/pkg/storage/apis/otto.gptscript.ai/v1/knowledgeset.go b/pkg/storage/apis/otto.gptscript.ai/v1/knowledgeset.go
@@ -46,6 +46,7 @@ type KnowledgeSetStatus struct {
 	ObservedIngestionGeneration int64  `json:"observedIngestionGeneration,omitempty"`
 	SuggestedDataDescription    string `json:"suggestedDataDescription,omitempty"`
 	WorkspaceName               string `json:"workspaceName,omitempty"`
+	IsEmpty                     bool   `json:"isEmpty,omitempty"`
 }
 
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

diff --git a/pkg/storage/openapi/generated/openapi_generated.go b/pkg/storage/openapi/generated/openapi_generated.go
-Original file line number
+Diff line change
@@ Expand Up @@
     	}
     	if len(files.Items) == 0 {
+    		ks.Status.IsEmpty = true
     		return nil
     	}
@@ Expand Down @@