fix: show confirm dialog only if content has been changed for workflo…

…w step (#1167)
obot-platform · Jan 9, 2025 · 8d2de63 · 8d2de63
1 parent 0cb644c
commit 8d2de63
Showing 1 changed file with 32 additions and 3 deletions.
diff --git a/ui/admin/app/components/workflow/steps/StepBase.tsx b/ui/admin/app/components/workflow/steps/StepBase.tsx
@@ -59,15 +59,26 @@ export function StepBase({
 
     const { intercept, dialogProps } = useConfirmationDialog();
 
-    const handleDelete = () =>
-        intercept(() => onDelete(), DeleteStepDialogProps);
+    const handleDelete = () => {
+        if (hasContent()) {
+            intercept(() => onDelete(), DeleteStepDialogProps);
+        } else {
+            onDelete();
+        }
+    };
 
     const handleUpdateType = (newType: StepType) => {
-        if (newType !== type) {
+        if (newType === type) {
+            return;
+        }
+
+        if (hasContent()) {
             intercept(
                 () => onUpdate(getDefaultStep(newType)),
                 UpdateStepTypeDialogProps
             );
+        } else {
+            onUpdate(getDefaultStep(newType));
         }
     };
     return (
@@ -155,4 +166,22 @@ export function StepBase({
             onChange: (value: string) => onUpdate({ ...step, step: value }),
         };
     }
+
+    function hasContent() {
+        const { workflows, tools } = step;
+        if (workflows.length || tools.length) {
+            return true;
+        }
+        if (type === "if" && step.if) {
+            return (
+                step.if.condition.length ||
+                step.if.else.length ||
+                step.if.steps.length
+            );
+        } else if (type === "while" && step.while) {
+            return step.while.condition.length || step.while.steps.length;
+        }
+
+        return step.step?.length;
+    }
 }