chore: refactor knowledge code in admin ui #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
LGTM. Walk down through the code with @ryanhopperlowe and it is working as expected.
Thanks for picking it up and refactor the code! Look much better
| if (blockPollingFiles) setBlockPollingFiles(false); | ||
| }; | ||
|
|
||
| if (knowledgeSource.state === KnowledgeSourceStatus.Syncing) { |
There was a problem hiding this comment.
you should also check for pending state. Something if sync happen to fast it will never fetch state from syncing given we are pulling every 5 seconds
There was a problem hiding this comment.
fixed! thanks!
StrongMonkey
approved these changes
Dec 20, 2024
ryanhopperlowe
force-pushed
the
chore/admin/refactor-knowledge
branch
from
2c8ed15 to
5abb422
Compare
This should have no effect on logic or UI/UX. it just extracts some subcomponents and abstracts data logic into reusable hooks. Doing this in preparation for thread level knowledge implementations
ryanhopperlowe
force-pushed
the
chore/admin/refactor-knowledge
branch
from
5abb422 to
b3c133a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have no effect on logic or UI/UX. it just extracts some subcomponents and abstracts data logic into reusable hooks.
Doing this in preparation for thread level knowledge implementations
Refactored largely using cursor